worker-protocol: embed features in Version and add Number inner type#15161
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 6, 2026
Merged
Conversation
github-actions
bot
added
new-cli
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Member
|
https://en.cppreference.com/w/cpp/utility/compare/partial_ordering.html for |
Member
|
https://en.cppreference.com/w/cpp/algorithm/includes.html may help with that |
amaanq
force-pushed
the
version-number-subtype
branch
2 times, most recently
from
0deffc7 to
549a409
Compare
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
amaanq
force-pushed
the
version-number-subtype
branch
2 times, most recently
from
ed44f05 to
be49329
Compare
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
amaanq
force-pushed
the
version-number-subtype
branch
3 times, most recently
from
e8da4c6 to
01f7674
Compare
amaanq
changed the title
Version and add Number subtype
amaanq
changed the title
Version and add Number subtypeVersion and add Number inner type
This commit embeds the negotiated `FeatureSet` directly into `WorkerProto::Version` and introduces a `Number` inner type with total ordering, so that `Version` itself (number + features) only has partial ordering. This is a follow-up to NixOS#15155, cleaning up the separate `features` fields on `ReadConn`/`WriteConn`. Co-authored-by: Amaan Qureshi <git@amaanq.com>
amaanq
force-pushed
the
version-number-subtype
branch
from
01f7674 to
7eb23c1
Compare
Ericson2314
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit embeds the negotiated
FeatureSetdirectly intoWorkerProto::Versionand introduces aNumberinner type with total ordering, so thatVersionitself (number + features) only has partial ordering.Context
This is a follow-up to #15155, cleaning up the separate
featuresfields onReadConn/WriteConn.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.